[CAMEL-9391] Set parameter enableEventsResending should be before Atmosphere wrap request

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.17.0
• Component/s: camel-atmosphere-websocket
• Labels: patch
• Estimated Complexity: Novice
• Assignee: Claus Ibsen
• Reporter: Pavlo Kletsko
• Created: 04/Dec/15 15:31
• Updated: 05/Dec/15 13:34
• Resolved: 05/Dec/15 13:34

Description

This is a defect regarding CAMEL-9364 feature.

WebsocketConsumer has service method where Atmosphere handle incoming request. In case value for enableEventsResending will be set after request is handled OnOpen event will not be sent at all.

Consequently, set this value should be before such as :
this.enableEventsResending = enableEventsResending;
framework.doCometSupport(AtmosphereRequest.wrap(request), AtmosphereResponse.wrap(response));

In addition to this because of CamelWebSocketServlet use init method for set enableEventsResending value, tests which were written for this feature are wrong. To solve this a new TestSupport class should be created where init parameter will be set correctly and tests depending on this parameter will be moved to separate class which extend the new TestSupport class.