[CAMEL-9274] StreamCache does not work correctly with MarshalProcessor and pretty much all DataFormats

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.16.0
• Fix Version/s: 2.17.0
• Component/s: camel-core
• Patch Info: Patch Available
• Assignee: Claus Ibsen
• Reporter: Aaron Whiteside
• Created: 29/Oct/15 21:44
• Updated: 18/Feb/16 15:50
• Resolved: 18/Feb/16 15:50

Description

StreamCache does not work correctly with MarshalProcessor and pretty much all DataFormats

1. Documentation states that stream caching can be turned on, on a per route basis. The places were we actually try and utilize stream caching only checks if the global option is turned on (MarshalProcessor + PGPKeyAccessDataFormat, I can't find any other meaningful attempts to use stream caching anywhere else) not the per route setting.
2. Secondly, if we ignore the first problem, only one data formatter tries to use stream caching for unmarshaling: PGPKeyAccessDataFormat. If you try and unzip a large zip file it's contents will be decompressed into memory. The same goes for any other large data formatter conversion (unmarshaling, only).

Attached is a patch that corrects the first problem and part of the second problem (ZipFileDataFormat, ZipDataFormat and PGPKeyAccessDataFormat).

A separate issue should probably be opened to fix all the remaining DataFormat implementation to support Stream Caching.