[CAMEL-9102] CxfEndpoint could use loggingSizeLimit = -1 for no size limit

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.15.3
• Fix Version/s: 2.16.0
• Component/s: camel-cxf, camel-cxfrs
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Bruno Marco Visioli
• Created: 26/Aug/15 12:38
• Updated: 04/Sep/15 08:21
• Resolved: 02/Sep/15 20:51

Description

When creating a CxfEndpoint, setting a loggingSizeLimit -1 to disable limiting payload logging cause no effect due to the code bellow. CXF own LoggingIn/OutInterceptor code accept -1 as unlimited.

org.apache.camel.component.cxf.CxfEndpoint

if (getLoggingSizeLimit() > 0) {
    sfb.getFeatures().add(new LoggingFeature(getLoggingSizeLimit()));
} else {
    sfb.getFeatures().add(new LoggingFeature());
}

org.apache.cxf.feature.LoggingFeature

private static final int DEFAULT_LIMIT = AbstractLoggingInterceptor.DEFAULT_LIMIT;
private static final LoggingInInterceptor IN = new LoggingInInterceptor(DEFAULT_LIMIT);
private static final LoggingOutInterceptor OUT = new LoggingOutInterceptor(DEFAULT_LIMIT);
int limit = DEFAULT_LIMIT;

public LoggingFeature() {}

protected void initializeProvider(InterceptorProvider provider, Bus bus) {
    if (limit == DEFAULT_LIMIT && inLocation == null && outLocation == null && !prettyLogging) {
        provider.getInInterceptors().add(IN);
        provider.getInFaultInterceptors().add(IN);
        provider.getOutInterceptors().add(OUT);
        provider.getOutFaultInterceptors().add(OUT);
    } else {
           //Creates and uses new Interceptors with specified limit
    }

org.apache.cxf.interceptor.LoggingInInterceptor

public LoggingInInterceptor(int lim) {
    this();
    limit = lim;
}

protected void logInputStream(Message message, InputStream is, LoggingMessage buffer, String encoding, String ct) {
(...)
    //only copy up to the limit since that's all we need to log
    //we can stream the rest
    IOUtils.copyAtLeast(bis, bos, limit == -1 ? Integer.MAX_VALUE : limit);