[CAMEL-8213] UseOriginalAggregationStrategy is suspicious to NullPointerException

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.14.1
• Fix Version/s: 2.13.4, 2.14.2, 2.15.0
• Component/s: camel-core
• Labels: nullpointerexception
• Assignee: Claus Ibsen
• Reporter: Steffen Ryll
• Created: 07/Jan/15 09:31
• Updated: 09/Jan/15 08:10
• Resolved: 09/Jan/15 08:10

Description

The default constructor of UseOriginalAggregationStrategy sets the final field original to null.
In one corner case, the aggregate will dereference this null pointer, as no null-pointer check is made.

    public Exchange aggregate(Exchange oldExchange, Exchange newExchange) {
        if (propagateException) {
            Exception exception = checkException(oldExchange, newExchange);
            if (exception != null) {
                original.setException(exception);
            }
        }
        return original != null ? original : oldExchange;
    }

This potential NPE should be fixed, maybe a unit test be added.