[CAMEL-7803] DefaultJdbcPrepareStatementStrategy Iterator fails on null value inserts

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.13.2
• Fix Version/s: 2.12.5, 2.13.3, 2.14.1, 2.15.0
• Component/s: camel-jdbc
• Patch Info: Patch Available
• Estimated Complexity: Unknown
• Assignee: Willem Jiang
• Reporter: Nathan Wray
• Created: 11/Sep/14 12:53
• Updated: 11/Nov/14 01:29
• Resolved: 16/Sep/14 13:09

Description

The iterator returned by createPopulateIterator in DefaultJdbcPrepareStatementStrategy incorrectly uses a next value of "null" to identify when it has run out of parameters. This fails when the parameter map intentionally contains a name with a null value, which is the case when some columns in an insert should be set to null. The attached pull request adds an explicit preFetch flag and relies on the done flag, avoiding the incorrect overloading of (next==null) to indicate completion.

The iterator reports "hasNext() == false" when it encounters a map value of null. This happens when using the map header JDBC_PARAMETERS = "CamelJdbcParameters" to insert null values with a prepared statement. The Iterator ends prematurely when it reaches a parameter name with a null value.

For example, passing in a map where the 3rd parameter of 19 has a value of null causes the following exception to be thrown:

java.sql.SQLException: Number of parameters mismatch. Expected: 19, was:2
at org.apache.camel.component.jdbc.DefaultJdbcPrepareStatementStrategy.populateStatement(DefaultJdbcPrepareStatementStrategy.java:137)
at org.apache.camel.component.jdbc.JdbcProducer.doCreateAndExecuteSqlStatementWithHeaders(JdbcProducer.java:133)
at org.apache.camel.component.jdbc.JdbcProducer.createAndExecuteSqlStatement(JdbcProducer.java:116)
at org.apache.camel.component.jdbc.JdbcProducer.processingSqlBySettingAutoCommit(JdbcProducer.java:85)