[CAMEL-7500] Concurrent modification of exchange during retry after netty TCP failure leads to futher processing of failed messages

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.13.1
• Fix Version/s: 2.15.3, 2.16.0
• Component/s: camel-netty
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Bob Browning
• Created: 11/Jun/14 17:03
• Updated: 15/Feb/21 16:53
• Resolved: 10/Jul/15 08:48

Description

When a exception occurs on a netty TCP channel such as ChanelClosedException then there are two invocations of the producer callback.

If there is a redelivery handler configured this causes either two threads to be added to the scheduled thread-pool which then compete or in the more common case the first invocation adds the redelivery thread but in doing so clears the exception from the exchange such that when the subsequent callback invocation occurs it see's the event as a success and continues routing of the exchange.

Note this also seems to be a cause of negative inflight messages on the route.

The first callback invocation occurs in the ChannelFutureListener which is the usual case.

The second callback invocation which comes from the ClientChannelHandler registered in the DefaultClientPipelineFactory used by the NettyProducer.

Issue Links

• relates to: CAMEL-16178 Enrich with REST+netty hangs when connection is closed without response