[CAMEL-7075] Veracode compliance. Improper Resource Shutdown or Release (CWE ID 404) in FileInputStreamCache

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.12.2
• Fix Version/s: 2.11.3, 2.12.3, 2.13.0
• Labels: Security Veracode
• Patch Info: Patch Available
• Estimated Complexity: Unknown
• Assignee: Willem Jiang
• Reporter: Leonid Marushevskiy
• Created: 17/Dec/13 10:23
• Updated: 18/Dec/13 06:33
• Resolved: 18/Dec/13 06:33

Description

Pull request https://github.com/apache/camel/pull/71

During Veracode scan of our application we discover issue in Camel. Please review our fix and apply it in future versions.

Quote from Veracode report below:
Improper Resource Shutdown or Release (CWE ID 404)(1 flaw)
Description
The application fails to release (or incorrectly releases) a system resource before it is made available for re-use. This
condition often occurs with resources such as database connections or file handles. Most unreleased resource issues
result in general software reliability problems, but if an attacker can intentionally trigger a resource leak, it may be
possible to launch a denial of service attack by depleting the resource pool.
Effort to Fix: 2 - Implementation error. Fix is approx. 6-50 lines of code. 1 day to fix.
Recommendations
When a resource is created or allocated, the developer is responsible for properly releasing the resource as well as
accounting for all potential paths of expiration or invalidation. Ensure that all code paths properly release resources.

.../FileInputStreamCache.java line 86