There're bunch of minor flaws by the ServiceHelper utility class such as:
- The stopAndShutdownServices(Collection<?> services) method has got a minor bug in that it does not stop each given service object inside the try/catch block. Potentially this could cause to miss stopping/shutting down the remaining elements of the given services collection in case calling stop on one of those service objects would throw an exception!
- The utility startServices(Object... services) has got code-duplication! Instead it should reuse the startServices(Collection<?> services) logic.
- Lack of Javadoc by bunch of it's utility methods.
- Some existing Javadoc is not really clear & precise about what the method exactly/really does.