Uploaded image for project: 'Camel'
  1. Camel
  2. CAMEL-6951

camel-core - Improve ServiceHelper utility class.

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.12.1
    • Fix Version/s: 2.11.3, 2.12.2, 2.13.0
    • Component/s: camel-core
    • Labels:
      None
    • Estimated Complexity:
      Unknown

      Description

      There're bunch of minor flaws by the ServiceHelper utility class such as:

      • The stopAndShutdownServices(Collection<?> services) method has got a minor bug in that it does not stop each given service object inside the try/catch block. Potentially this could cause to miss stopping/shutting down the remaining elements of the given services collection in case calling stop on one of those service objects would throw an exception!
      • The utility startServices(Object... services) has got code-duplication! Instead it should reuse the startServices(Collection<?> services) logic.
      • Lack of Javadoc by bunch of it's utility methods.
      • Some existing Javadoc is not really clear & precise about what the method exactly/really does.

        Attachments

          Activity

            People

            • Assignee:
              bvahdat Babak Vahdat
              Reporter:
              bvahdat Babak Vahdat
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: