[CAMEL-6551] FtpConsumer fills up log file with "Cannot connect/login" WARN level messages

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.10.4
• Fix Version/s: 2.10.6, 2.11.2
• Component/s: camel-ftp

Environment

Windows7-64, JRE-1.6 - but not environment-specific

• Estimated Complexity: Unknown
• Assignee: Willem Jiang
• Reporter: Chris Wolf
• Created: 15/Jul/13 20:52
• Updated: 09/Dec/13 06:37
• Resolved: 09/Dec/13 06:37

Description

If the FTP server becomes unavailable, the container log gets flooded with WARN-level messages and gets filled with lines like:
16:32:34,511 WARN [org.apache.camel.component.file.remote.FtpConsumer] Cannot connect/login to: ftp://adpt5@localhost:21. Will skip this poll.
16:32:49,048 WARN [org.apache.camel.component.file.remote.FtpConsumer] Cannot connect/login to: ftp://adpt5@localhost:21. Will skip this poll.
16:33:03,576 WARN [org.apache.camel.component.file.remote.FtpConsumer] Cannot connect/login to: ftp://adpt5@localhost:21. Will skip this poll.

i.e. a WARN message gets added to the log every five seconds. We only need to be notified once per incidence.

The issue is in org.apache.camel.component.file.remote.RemoteFileConsumer.prePollCheck().

I recommend a table of latches, keyed by endpoint key. The latch is set when the initial warning is logged, then cleared upon any subsequent successful connection.