[CAMEL-5983] Avoid the negative-tests to behave as false-positive

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.10.3
• Fix Version/s: 2.10.4, 2.11.0
• Component/s: tests
• Estimated Complexity: Unknown
• Assignee: Babak Vahdat
• Reporter: Babak Vahdat
• Created: 20/Jan/13 10:09
• Updated: 21/Jan/13 20:51
• Resolved: 21/Jan/13 20:51

Description

We've got bunch of (negative) tests on the current codebase expecting a thrown XYZException however they don't realize if the expected exception is not thrown, the typical pattern for this is:

try {
 doSomething_With_Expectation_Of_A_Thrown_XYZException();
} catch (XYZException e) {
 // expected
}

Which correctly should be:

try {
 doSomething_With_Expectation_Of_A_Thrown_XYZException();
 fail("Should have thrown an exception");
} catch (XYZException e) {
 // expected
}