Camel
  1. Camel
  2. CAMEL-5751

Fix Camel trunk fulltest for Java 7 at Jenkins

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.10.2
    • Fix Version/s: 2.11.0
    • Component/s: build system
    • Labels:
      None
    • Estimated Complexity:
      Unknown

      Activity

      Hide
      Claus Ibsen added a comment -
      Show
      Claus Ibsen added a comment - Seems like camel-quickfix has some JMX issue with Java7 https://builds.apache.org/job/Camel.trunk.fulltest.java7/org.apache.camel$camel-quickfix/344/testReport/
      Hide
      Babak Vahdat added a comment -

      The behaviour of QuickfixjEngineTest by camel-quickfix on JDK 7 is undeterministic, e.g. looking at the builds #330...#338 which all passed green without any change by the code base since October 19th:

      https://builds.apache.org/job/Camel.trunk.fulltest.java7/org.apache.camel$camel-quickfix/

      And suddenly the last two test runs failed again (#343...#344)!

      I played pretty long on this issue and even after resolving CAMEL-5686 this random behaviour is still there. Just wonder if we should really skip these tests on JDK 7. More details also @dev forum:
      http://camel.465427.n5.nabble.com/Getting-closer-with-Java7-tp5692627p5720709.html

      Show
      Babak Vahdat added a comment - The behaviour of QuickfixjEngineTest by camel-quickfix on JDK 7 is undeterministic, e.g. looking at the builds #330...#338 which all passed green without any change by the code base since October 19th: https://builds.apache.org/job/Camel.trunk.fulltest.java7/org.apache.camel$camel-quickfix/ And suddenly the last two test runs failed again (#343...#344)! I played pretty long on this issue and even after resolving CAMEL-5686 this random behaviour is still there. Just wonder if we should really skip these tests on JDK 7. More details also @dev forum: http://camel.465427.n5.nabble.com/Getting-closer-with-Java7-tp5692627p5720709.html
      Hide
      Christian Müller added a comment -

      +1 for skipping the tests on Java 7 for camel-quickfix

      Show
      Christian Müller added a comment - +1 for skipping the tests on Java 7 for camel-quickfix
      Hide
      Claus Ibsen added a comment -

      +1 for skipping on java7.

      Show
      Claus Ibsen added a comment - +1 for skipping on java7.
      Hide
      Babak Vahdat added a comment -

      O.K. for sake of not loosing the whole code coverage by these tests, now only the single assert failing from time to time has been disabled on JDK 7:

      http://svn.apache.org/viewvc/camel/trunk/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/QuickfixjEngineTest.java?r1=1404303&r2=1404302&pathrev=1404303

      Show
      Babak Vahdat added a comment - O.K. for sake of not loosing the whole code coverage by these tests, now only the single assert failing from time to time has been disabled on JDK 7: http://svn.apache.org/viewvc/camel/trunk/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/QuickfixjEngineTest.java?r1=1404303&r2=1404302&pathrev=1404303
      Hide
      Christian Müller added a comment -

      Thanks Babak. Do you consider to report this issue to the quickfix guys?

      Show
      Christian Müller added a comment - Thanks Babak. Do you consider to report this issue to the quickfix guys?
      Hide
      Babak Vahdat added a comment -

      Yes of course.

      Show
      Babak Vahdat added a comment - Yes of course.
      Show
      Babak Vahdat added a comment - Raised http://www.quickfixj.org/jira/browse/QFJ-713
      Hide
      Claus Ibsen added a comment -

      The last test was a success so we are on the right track now.

      Show
      Claus Ibsen added a comment - The last test was a success so we are on the right track now.
      Hide
      Christian Müller added a comment -

      I love it!

      Show
      Christian Müller added a comment - I love it!
      Hide
      Babak Vahdat added a comment -

      Christoph John, one of the QuickFixJ committer gave a good hint, so that IMHO it's worth to give it a last try to see if this would resolve the problem. I'll watch the build for one week to see if this would to the trick:

      http://svn.apache.org/viewvc?view=revision&revision=1405932

      So please be a bit patient with this ticket. Thanks!

      Show
      Babak Vahdat added a comment - Christoph John, one of the QuickFixJ committer gave a good hint , so that IMHO it's worth to give it a last try to see if this would resolve the problem. I'll watch the build for one week to see if this would to the trick: http://svn.apache.org/viewvc?view=revision&revision=1405932 So please be a bit patient with this ticket. Thanks!
      Hide
      Babak Vahdat added a comment -

      Backported this fix to the 2.10.x branch as well (because of the JDK 7 support since 2.10.0).

      Show
      Babak Vahdat added a comment - Backported this fix to the 2.10.x branch as well (because of the JDK 7 support since 2.10.0).
      Hide
      Babak Vahdat added a comment -

      There has been no single test failure on the CI-Server since the fix, following the last run from yesterday:

      https://builds.apache.org/job/Camel.trunk.fulltest.java7/356/org.apache.camel$camel-quickfix/testReport/org.apache.camel.component.quickfixj/QuickfixjEngineTest/

      Still keeping my fingers crossed

      Show
      Babak Vahdat added a comment - There has been no single test failure on the CI-Server since the fix, following the last run from yesterday: https://builds.apache.org/job/Camel.trunk.fulltest.java7/356/org.apache.camel$camel-quickfix/testReport/org.apache.camel.component.quickfixj/QuickfixjEngineTest/ Still keeping my fingers crossed
      Hide
      Babak Vahdat added a comment -

      I asked Christoph John to close QFJ-713 as the problem really seems to be resolved:

      http://www.quickfixj.org/jira/browse/QFJ-713

      In the next days I'll still keep an eye on the the JDK 7 profile about this.

      Show
      Babak Vahdat added a comment - I asked Christoph John to close QFJ-713 as the problem really seems to be resolved: http://www.quickfixj.org/jira/browse/QFJ-713 In the next days I'll still keep an eye on the the JDK 7 profile about this.
      Hide
      Babak Vahdat added a comment -

      The latest build was a success (mostly because of Claus hard work on differnet module tests in the last weeks):

      https://builds.apache.org/job/Camel.trunk.fulltest.java7/372/

      And the problem with QuickfixjEngineTest camel-quickfix on JDK 7 seems definitely to be resolved (with thanks to Christoph John for the hint).

      These all said, there're still some tests failing randomly from time to time so that we should still keep an eye on all the profiles to spot and fix them, like the ones I fixed recently by camel-cxf:

      http://svn.apache.org/viewvc?view=revision&revision=1411217

      Show
      Babak Vahdat added a comment - The latest build was a success (mostly because of Claus hard work on differnet module tests in the last weeks): https://builds.apache.org/job/Camel.trunk.fulltest.java7/372/ And the problem with QuickfixjEngineTest camel-quickfix on JDK 7 seems definitely to be resolved (with thanks to Christoph John for the hint). These all said, there're still some tests failing randomly from time to time so that we should still keep an eye on all the profiles to spot and fix them, like the ones I fixed recently by camel-cxf: http://svn.apache.org/viewvc?view=revision&revision=1411217

        People

        • Assignee:
          Babak Vahdat
          Reporter:
          Christian Müller
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development