[CAMEL-547] remove cycle between builder and spi

• Type: Improvement
• Status: Closed
• Priority: Critical
• Resolution: Duplicate
• Affects Version/s: 1.3.0
• Fix Version/s: 1.4.0
• Component/s: camel-core
• Assignee: Hadrian Zbarcea
• Reporter: Christian Schneider
• Created: 24/May/08 16:40
• Updated: 14/Jul/08 14:48
• Resolved: 08/Jun/08 11:22

Description

Currently the spi package references builder.RouteBuilder. This creates a bad cycle in Camel as builder is one of the top level packages and spi is one of the lowest level packages. The method where RouteBuilder is used is in CamelContext.addRoutes(RouteBuilder builder). I think this reference is not necessary. CamelContext already has a method addRoutes(Collection<Route> routes).

So instead of calling camelContext.addRoutes(builder) I think the better way would to call:
builder.setContext(camelContext);
builder.addRoutesToContext(); // This is a new method that replaces the functionality of CamelContext.addRoutes(RouteBuilder builder)

This way we will also cut some part of the cycle between impl and builder. impl.DefaultCamelContext references both RouteBuilder and BuilderSupport from the builder package. Both will not be necessary anymore as as soon as we get rid of the addRoutes method.

This way CamelContext does not have to know anything about it´s builder. What do you think about this change?

Issue Links

• is superceded by: CAMEL-588 Remove cycle between camel, spi and model

Sub-Tasks

• Break dependency cycle between camel and camel.impl: Closed