Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0, 1.4.0
    • Fix Version/s: 2.0-M1
    • Component/s: camel-core
    • Labels:
      None

      Description

      I have found one other problem in RouteContext. The method intercept uses the class Interceptor from processor. I think Interceptor should be an interface that should reside in spi or camel. So we could avoid referencing the processor package from spi.

      When I look into the current Interceptor implementation I think the two main methods that need to be in the interface are process and proceed. Process can be inherited from Processor but proceed is only declared in the implementation class DelegateProcessor. So I think the clean way to handle this would be to create an interface DelegateProcessor and a spearate DefaultDelegateProcessor.

      public interface DelegateProcessor extends Processor

      { /** * Proceed with the underlying delegated processor */ public abstract void proceed(Exchange exchange) throws Exception; }

      and an interface Interceptor

      public interface Interceptor extends DelegateProcessor {
      public abstract void process(Exchange exchange) throws Exception; public abstract Processor getInterceptorLogic(); public abstract void setInterceptorLogic(Processor interceptorLogic);
      }

      When we put these to spi and use them instead of the implementations where possible the spi would not depend on processor anymore.

      1. interceptor.patch
        32 kB
        Christian Schneider

        Activity

          People

          • Assignee:
            Claus Ibsen
            Reporter:
            Christian Schneider
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development