[CAMEL-5225] camel-netty can't distinguish between Sharable and Unsharable codecs

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.9.2
• Fix Version/s: 2.9.3, 2.10.0
• Component/s: camel-netty
• Labels: netty

Environment

ALL

• Estimated Complexity: Advanced
• Assignee: Claus Ibsen
• Reporter: edge wang
• Created: 26/Apr/12 16:03
• Updated: 13/Jun/12 09:33
• Resolved: 08/Jun/12 15:30

Description

Camel-netty uses general configuration model for referenced encoders/decoders for channel pipelines, see DefaultServerPipelineFactory. That is, create encoder/decoder objects at configuration parsing time and store them in a list, then use them when a pipeline is established. However, this will make encoder/decoder objects shared among different pipelines, that may cause data conflicts, when the encoder/decoder is not Sharable(has object status/not annotated as @Sharable), e.g. a LengthFieldBasedFrameDecoder.

Although we can avoid the problem by totally writing a new serverpipelinefactory for our apps, several problem still remains, please see detailed description and testcase for this bug at:

http://camel.465427.n5.nabble.com/camel-netty-bug-and-the-need-of-best-practice-for-creating-referenced-parameter-object-on-looking-up-td5627926.html