Camel
  1. Camel
  2. CAMEL-4396

XML validation errors should be not logged on System.err

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.1, 2.9.0
    • Component/s: camel-core
    • Labels:
      None
    • Patch Info:
      Patch Available
    • Estimated Complexity:
      Novice

      Description

      When a XSLT has validation errors, these errors do not appear in the log4j logs but instead are printed as "System.err".
      A simple change to the XmlConverter class of camel-core and a custom XmlErrorListener fixes that (see attachment).
      Please consider the patch for inclusion.
      Thanks.

      1. camel_xml_exceptions3.patch
        0.8 kB
        metatech
      2. camel_xml_exceptions2.patch
        0.9 kB
        metatech
      3. camel_xml_exceptions1.patch
        0.5 kB
        metatech

        Activity

        Hide
        Christian Müller added a comment -

        Committed r1163420

        Thanks for the patch.

        Show
        Christian Müller added a comment - Committed r1163420 Thanks for the patch.
        Hide
        metatech added a comment -

        The 2 previous patches cover the case where the XSLT document itself has XML errors.
        This third patch covers the case where the XML document in the request body is has XML errors.
        Please also include this patch.
        Thanks.

        Show
        metatech added a comment - The 2 previous patches cover the case where the XSLT document itself has XML errors. This third patch covers the case where the XML document in the request body is has XML errors. Please also include this patch. Thanks.
        Hide
        metatech added a comment -

        New patch is provided.

        Show
        metatech added a comment - New patch is provided.
        Hide
        Claus Ibsen added a comment -

        Thanks for the 3rd patch. I have applied it to trunk. And backported the entire fix to 2.8.x as well.

        Show
        Claus Ibsen added a comment - Thanks for the 3rd patch. I have applied it to trunk. And backported the entire fix to 2.8.x as well.

          People

          • Assignee:
            Christian Müller
            Reporter:
            metatech
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development