[CAMEL-4246] TraceInterceptor does not work correctly for AsyncProcessing

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.1
• Fix Version/s: 2.8.1, 2.9.0
• Component/s: camel-core
• Assignee: Claus Ibsen
• Reporter: Yaytay
• Created: 19/Jul/11 11:34
• Updated: 02/Sep/11 09:51
• Resolved: 22/Jul/11 11:33

Description

TraceEventHandlers are not called correctly when a node is processed asynchronously.

From org.apache.camel.processor.interceptor.TraceInterceptor:
try {
// special for interceptor where we need to keep booking how far we have routed in the intercepted processors
if (node.getParent() instanceof InterceptDefinition && exchange.getUnitOfWork() != null)

{ TracedRouteNodes traced = exchange.getUnitOfWork().getTracedRouteNodes(); traceIntercept((InterceptDefinition) node.getParent(), traced, exchange); }

// process the exchange
try

{ sync = super.process(exchange, callback); }

catch (Throwable e)

{ exchange.setException(e); }

} finally {
// after (trace out)
if (shouldLog && tracer.isTraceOutExchanges())

{ logExchange(exchange); traceExchangeOut(exchange, traceState); }

}

As it is this results in traceExchangeOut being called before the callback, which is wrong.
The call to super.process needs to wrap the callback to call traceExchangeOut (and the finally block shouldn't run if the process is asynch).

This isn't a regression, but the change to make more routes asynchronous makes it more noticeable.