Camel
  1. Camel
  2. CAMEL-3735

Upgrade to Spring WS 2.0.2 with OSGi fix

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0
    • Component/s: osgi
    • Labels:
      None

      Description

      Spring WS 2.0.0 release is not OSGi compliant.

      When it's OSGi compliant we should upgrade the camel-spring-ws feature, which currently use the old 1.5.9 release.
      There is TODO in the features.xml and pom.xml file in platforms/karaf/features dir.

      1. CAMEL-3735-v1.patch
        3 kB
        Richard Kettelerij

        Issue Links

          Activity

          Claus Ibsen created issue -
          Claus Ibsen made changes -
          Field Original Value New Value
          Link This issue relates to CAMEL-3659 [ CAMEL-3659 ]
          Hide
          Claus Ibsen added a comment -
          Show
          Claus Ibsen added a comment - This is the Spring WS bug https://jira.springsource.org/browse/SWS-681
          Hide
          Richard Kettelerij added a comment -

          The Spring-WS bug is resolved now (there's a snapshot version available). We'll just have to wait until 2.0.1 is final.

          Show
          Richard Kettelerij added a comment - The Spring-WS bug is resolved now (there's a snapshot version available). We'll just have to wait until 2.0.1 is final.
          Hide
          Claus Ibsen added a comment -

          2.0.1 has been released now. Richard do you mind taking a look at this?

          Show
          Claus Ibsen added a comment - 2.0.1 has been released now. Richard do you mind taking a look at this?
          Claus Ibsen made changes -
          Assignee Richard Kettelerij [ rkettelerij ]
          Hide
          Richard Kettelerij added a comment -

          Sure I'll take a look.

          Show
          Richard Kettelerij added a comment - Sure I'll take a look.
          Hide
          Richard Kettelerij added a comment - - edited

          I've taken a stab at this issue: upgraded to Spring-WS 2.0.1 and updated the Karaf features file (see attached patch).

          However there might be an issue with this patch: Spring-WS requires amongst others "javax.xml.transform.stax" as a mandatory import. Running mvn -Pvalidate clean install on features.xml fails with "No export found to match javax.xml.transform.stax;version=0". Adding the ServiceMix StAX spec as a dependency makes no difference.

          The only solution I could find was to switch Karaf to Java 1.6, like I did in the attached patch. Would that be a problem for Camel? Camel 2.7+ only supports Java 1.6 but the latest Karaf version (2.2) still supports Java 1.5?

          Furthermore the CamelSpringWebServiceTest test written by Claus in CAMEL-3307 still fails under Spring-WS 2.0.1, this was also the case with Spring-WS 1.5.9....

          Show
          Richard Kettelerij added a comment - - edited I've taken a stab at this issue: upgraded to Spring-WS 2.0.1 and updated the Karaf features file (see attached patch). However there might be an issue with this patch: Spring-WS requires amongst others "javax.xml.transform.stax" as a mandatory import. Running mvn -Pvalidate clean install on features.xml fails with "No export found to match javax.xml.transform.stax;version=0". Adding the ServiceMix StAX spec as a dependency makes no difference. The only solution I could find was to switch Karaf to Java 1.6, like I did in the attached patch. Would that be a problem for Camel? Camel 2.7+ only supports Java 1.6 but the latest Karaf version (2.2) still supports Java 1.5? Furthermore the CamelSpringWebServiceTest test written by Claus in CAMEL-3307 still fails under Spring-WS 2.0.1, this was also the case with Spring-WS 1.5.9....
          Richard Kettelerij made changes -
          Attachment CAMEL-3735-v1.patch [ 12475939 ]
          Hide
          Claus Ibsen added a comment - - edited

          I think the test may work only on either one of the 2 osgi containers back in the days.

          Yeah Camel 2.7+ onwards is Java6+ only so its okay to not run at all on java1.5.

          And from Camel 2.8 we upgrade to Karaf 2.2.x+ so its also fine if the feature only works with that version.

          Show
          Claus Ibsen added a comment - - edited I think the test may work only on either one of the 2 osgi containers back in the days. Yeah Camel 2.7+ onwards is Java6+ only so its okay to not run at all on java1.5. And from Camel 2.8 we upgrade to Karaf 2.2.x+ so its also fine if the feature only works with that version.
          Hide
          Claus Ibsen added a comment -

          Richard Spring WS 2.0.2 has been released.

          Show
          Claus Ibsen added a comment - Richard Spring WS 2.0.2 has been released.
          Claus Ibsen made changes -
          Summary Upgrade to Spring WS 2.0.1 with OSGi fix Upgrade to Spring WS 2.0.2 with OSGi fix
          Richard Kettelerij made changes -
          Link This issue is blocked by CAMEL-3995 [ CAMEL-3995 ]
          Hide
          Claus Ibsen added a comment -

          Richard you can revert the patch from CAMEL-3995 in your local build and try to get the Spring WS 2.0.2 upgraded. It would be great to have this ready before we cut Camel 2.8

          Show
          Claus Ibsen added a comment - Richard you can revert the patch from CAMEL-3995 in your local build and try to get the Spring WS 2.0.2 upgraded. It would be great to have this ready before we cut Camel 2.8
          Richard Kettelerij made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Richard Kettelerij added a comment -

          Upgraded to Spring-WS 2.0.2. This required setting the Karaf features validation plugin to Java 1.6.

          Show
          Richard Kettelerij added a comment - Upgraded to Spring-WS 2.0.2. This required setting the Karaf features validation plugin to Java 1.6.
          Richard Kettelerij made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Claus Ibsen added a comment -

          The test in camel-test-karaf still fails. But I recall it failed for Spring WS 1.x as well.

          Show
          Claus Ibsen added a comment - The test in camel-test-karaf still fails. But I recall it failed for Spring WS 1.x as well.
          Hide
          Richard Kettelerij added a comment -

          Indeed that test has never worked. See CAMEL-3307 as mentioned above for details, the test is currently @Ignore(d).

          Show
          Richard Kettelerij added a comment - Indeed that test has never worked. See CAMEL-3307 as mentioned above for details, the test is currently @Ignore(d).

            People

            • Assignee:
              Richard Kettelerij
              Reporter:
              Claus Ibsen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development