Camel
  1. Camel
  2. CAMEL-3692

badly named getter methods for type "Boolean"

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.0
    • Component/s: None
    • Labels:
      None

      Description

      Since changing loads of types from "boolean" -> "Boolean", we left many of the getter methods using "isFoo" rather than changing them to the Java Beans compliant "getFoo". Breaking the Java Beans specification for naming properties can cause issues with libraries and tools; since the property is no longer introspectable or readable in any introspection based tool (of which there are loads around).

      e.g. go to camel-core/src/main/java/org/apache/camel/model/ then in your IDE search for "Boolean is". Those isFoo methods returning Boolean should be returned isFoo.

      For completeness we could also generate an isFoo for backwards compatibility that looks like...

      public boolean isFoo()

      { return foo != null && foo.booleanValue(); }

        Activity

        james strachan created issue -
        Claus Ibsen made changes -
        Field Original Value New Value
        Assignee Claus Ibsen [ davsclaus ]
        Claus Ibsen made changes -
        Issue Type New Feature [ 2 ] Improvement [ 4 ]
        Hide
        Claus Ibsen added a comment -

        trunk: 1073239.

        Show
        Claus Ibsen added a comment - trunk: 1073239.
        Claus Ibsen made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Daniel Kulp made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        19h 1m 1 Claus Ibsen 22/Feb/11 08:01
        Resolved Resolved Closed Closed
        245d 3h 34m 1 Daniel Kulp 25/Oct/11 12:35

          People

          • Assignee:
            Claus Ibsen
            Reporter:
            james strachan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development