Camel
  1. Camel
  2. CAMEL-3547

Custom "absorbing" PropertyPlaceholderConfigurer

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.0
    • Fix Version/s: 2.10.0
    • Component/s: camel-spring
    • Labels:
      None

      Description

      I find Camel's property placeholder support clumsy. I already use Spring's PropertyPlaceholderConfigurer, and I feel like Camel should be able to harness that. I realize Spring doesn't make it easy to access those properties, but I have come up with a way to enable Camel to use them...

      By simply extending PropertyPlaceholderConfigurer, we will be able to intercept and absorb the properties that Spring has access to:

      {{
      import java.util.Properties;
      import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
      import org.springframework.beans.factory.config.PropertyPlaceholderConfigurer;

      public class CamelPropertyPlaceholderConfigurer extends PropertyPlaceholderConfigurer {
      private final Properties properties = new Properties();

      @Override
      protected void processProperties(ConfigurableListableBeanFactory beanFactory, Properties props)

      { super.processProperties(beanFactory, props); // "Absorb" all properties that pass through so we can expose them later properties.putAll(props); }

      /** Expose all absorbed properties */
      public final Properties getProperties()

      { return properties; }

      }
      }}

      It means users who want to take advantage of this would need to instantiate this instead of the stock PropertyPlaceholderConfigurer, but that's no problem:

      <bean class="org.apache.camel.impl.CamelPropertyPlaceholderConfigurer">
      <p:location="..."/>
      </bean>

      That way, you wouldn't need to declare a "duplicating" <propertyPlaceholer> in the CamelContext. What do you think, is this feasible?

        Activity

        Hide
        Claus Ibsen added a comment -

        We'll it would be much better if the community vote on this ticket in Spring Framework:
        https://jira.springframework.org/browse/SPR-4466

        But I guess since the issue is almost 3 years old and still no sign from SS to raise to the occasion, we should consider alternatives.

        Show
        Claus Ibsen added a comment - We'll it would be much better if the community vote on this ticket in Spring Framework: https://jira.springframework.org/browse/SPR-4466 But I guess since the issue is almost 3 years old and still no sign from SS to raise to the occasion, we should consider alternatives.
        Show
        Claus Ibsen added a comment - Updated docs at https://cwiki.apache.org/confluence/display/CAMEL/Using+PropertyPlaceholder
        Hide
        Dan Checkoway added a comment -

        Thanks, Claus!

        Show
        Dan Checkoway added a comment - Thanks, Claus!

          People

          • Assignee:
            Claus Ibsen
            Reporter:
            Dan Checkoway
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development