[CAMEL-3189] Completed aggregated exchanges are never confirmed in the AggregationRepository

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.5.0
• Assignee: Claus Ibsen
• Reporter: Glenn Moss
• Created: 01/Oct/10 23:38
• Updated: 24/Apr/11 09:58
• Resolved: 02/Oct/10 07:58

Description

Under certain circumstances, the completed exchanges from an aggregator would remain in the AggregationRepository and redeliver after a restart of Camel. These exchanges had already successfully completed their route, so this redelivery is in error.

My guess is that in the AggregationProcessor on line 374, the AggregateOnCompletion gets added to a UnitOfWork that doesn't ever get done() called on it... or something.

I seemed to be able to prevent the problem by changing my AggregationStrategy. The old version looked like this:

public Exchange aggregate (Exchange oldExchange, Exchange newExchange) {
  String body = "";
  if (oldExchange != null) {
    body = oldExchange.getIn().getBody(String.class);
  }
  body += newExchange.getIn().getBody(String.class);
 newExchange.getIn().setBody(body);
 return newExchange;
}

You can see that the exchanges are aggregated into the newExchange. I changed it to aggregate into the oldExchange:

public Exchange aggregate (Exchange oldExchange, Exchange newExchange) {
  String body = "";
  if (oldExchange != null) {
    body = oldExchange.getIn().getBody(String.class);
  } else {
    oldExchange = newExchange;
  }

  body += newExchange.getIn().getBody(String.class);
  oldExchange.getIn().setBody(body);
 return oldExchange;
}