Uploaded image for project: 'Camel'
  1. Camel
  2. CAMEL-20194

Rename container.properties files in test-infra

    XMLWordPrintableJSON

Details

    • Test
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 4.3.0
    • tests
    • None
    • Unknown

    Description

      Each test-infra module contains a file named container.properties that is used to externalize container properties (docker images).

      When using two test infra modules, for example, the kafka one and the aws one, since the properties file have the same name, only one gets loaded and an exception like this can be observed in logs

      Caused by: java.lang.NullPointerException: Cannot invoke "String.indexOf(int)" because "fullImageName" is null
              at org.testcontainers.utility.DockerImageName.<init>(DockerImageName.java:71)
              at org.testcontainers.utility.DockerImageName.parse(DockerImageName.java:57)
              at org.testcontainers.containers.GenericContainer.<init>(GenericContainer.java:256)
              at org.apache.camel.test.infra.aws2.services.AWSContainer.<init>(AWSContainer.java:55)
      

      I wonder if the code can be refactored so that properties file can have unique names (kafka-container.properties or aws-container.properties for example) in order to avoid name clash when using multiple test-infra modules.

      Attachments

        Activity

          People

            orpiske Otavio Rodolfo Piske
            Federico Mariani Federico Mariani
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: