[CAMEL-19660] camel-mapstruct: Improve support for Mappers defined as abstract classes

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.20.7, 3.21.1, 3.22.0, 4.0.0
• Component/s: camel-mapstruct
• Estimated Complexity: Unknown
• Assignee: James Netherton
• Reporter: James Netherton
• Created: 26/Jul/23 13:51
• Updated: 27/Jul/23 04:18
• Resolved: 27/Jul/23 04:18

Description

If you define MapStruct mappings using an abstract class, then some unwanted TypeConverters get registered for the equals and wait methods. In the logs you see:

Added MapStruct type converter: long -> void
Added MapStruct type converter: class java.lang.Object -> boolean

This happens because they pass the DefaultMapStructFinder.discoverMappings check for a single method arg ,but the void return type is checked against Void.class and not the primitive void.class. We should probably just filter out anything with a primitive return type.

Issue Links

• links to: GitHub Pull Request #10838
• links to: GitHub Pull Request #10843
• links to: GitHub Pull Request #10844
• links to: GitHub Pull Request #10845