Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-M2
    • Fix Version/s: 2.2.0
    • Component/s: camel-ftp
    • Labels:
      None

      Description

      Apache Commons Net should now support FTPS (regular FTP with SSL)
      http://commons.apache.org/net/

      We should support that as well in Camel. If time permits get it into 2.0 as it should be nearly as the regular FTP from commons-net

      1. camel-ftp-polishedTests.patch
        97 kB
        Christian Müller
      2. camel-ftps-20091207.patch
        122 kB
        Christian Müller
      3. server.jks
        2 kB
        Christian Müller
      4. client.jks
        2 kB
        Christian Müller
      5. camel-ftps-20091206.patch
        95 kB
        Christian Müller
      6. camel-ftps-20091201-workInProgress.patch
        64 kB
        Christian Müller

        Activity

        Hide
        Claus Ibsen added a comment -

        Thanks Christian I have applied the polished patch.

        trunk: 889125.

        Show
        Claus Ibsen added a comment - Thanks Christian I have applied the polished patch. trunk: 889125.
        Hide
        Christian Müller added a comment -

        Claus, I polished the unit tests, removed unnecessary "deleteDirectory" calls and annotated two more test methods with @Test (see camel-ftp-polishedTests.patch).

        Show
        Christian Müller added a comment - Claus, I polished the unit tests, removed unnecessary "deleteDirectory" calls and annotated two more test methods with @Test (see camel-ftp-polishedTests.patch).
        Hide
        Claus Ibsen added a comment -

        Marat, camel-ftp already have FTP over SSH which is the SFTP component.

        Show
        Claus Ibsen added a comment - Marat, camel-ftp already have FTP over SSH which is the SFTP component.
        Hide
        Claus Ibsen added a comment -

        Christian yeah please feel free to submit a new patch with the latest test improvements

        Show
        Claus Ibsen added a comment - Christian yeah please feel free to submit a new patch with the latest test improvements
        Hide
        Marat Bedretdinov added a comment -

        Hi Christian, Claus,

        Take a look at http://www.jcraft.com/jsch/ You can use this to add FTP over SSH to camel runtime, which is available pretty much anywhere where there is an ssh daemon.

        Show
        Marat Bedretdinov added a comment - Hi Christian, Claus, Take a look at http://www.jcraft.com/jsch/ You can use this to add FTP over SSH to camel runtime, which is available pretty much anywhere where there is an ssh daemon.
        Hide
        Christian Müller added a comment -

        @Claus,

        many thanks!
        I updated the ftp2 component page and the release page.
        Do you interested in a separate patch with the test improvements?

        Regards,
        Christian

        Show
        Christian Müller added a comment - @Claus, many thanks! I updated the ftp2 component page and the release page. Do you interested in a separate patch with the test improvements? Regards, Christian
        Hide
        Claus Ibsen added a comment -

        Christian thanks a lot for this one, this is a great patch.

        Do you mind looking at updating the wiki page.

        And add a note on release notes for 2.2 that we got this great feature now
        http://camel.apache.org/camel-220-release.html

        Show
        Claus Ibsen added a comment - Christian thanks a lot for this one, this is a great patch. Do you mind looking at updating the wiki page. And add a note on release notes for 2.2 that we got this great feature now http://camel.apache.org/camel-220-release.html
        Hide
        Claus Ibsen added a comment -

        I have committed the patch (although not the very last)

        trunk: 888048.

        I also upgrade to newer version of FTP test server.
        I polished the javadoc.
        I removed that rouge unit test as its doesnt test a valid point, just showing some end user doing some strange stuff with Camel

        Show
        Claus Ibsen added a comment - I have committed the patch (although not the very last) trunk: 888048. I also upgrade to newer version of FTP test server. I polished the javadoc. I removed that rouge unit test as its doesnt test a valid point, just showing some end user doing some strange stuff with Camel
        Hide
        Christian Müller added a comment -

        @Claus: I attached a new version of this patch which includes two changes:

        1. removed some deleteDirectory(FTP_ROOT_DIR); calls in the concrete unit tests, because this is done in the FtpServerTestSupport class
        2. key store and trust store not included

        Note: In the current TRUNK (and also with this contribution), the unit test "FtpPollingConsumerTest" fails, if executed in maven or as batch in eclipse (all unit tests in the folder 'src/test/java'). But if I run this test alone, it succeed. I don't know why...

        Christian

        Show
        Christian Müller added a comment - @Claus: I attached a new version of this patch which includes two changes: 1. removed some deleteDirectory(FTP_ROOT_DIR); calls in the concrete unit tests, because this is done in the FtpServerTestSupport class 2. key store and trust store not included Note: In the current TRUNK (and also with this contribution), the unit test "FtpPollingConsumerTest" fails, if executed in maven or as batch in eclipse (all unit tests in the folder 'src/test/java'). But if I run this test alone, it succeed. I don't know why... Christian
        Hide
        Christian Müller added a comment -

        The key and trust store are "borrowed" from the Apache Mina ftpserver-core project

        Show
        Christian Müller added a comment - The key and trust store are "borrowed" from the Apache Mina ftpserver-core project
        Hide
        Claus Ibsen added a comment -

        Christian looks awesome.

        Can you attach the .jks files as individual files to this ticket as I got trouble extracting them from the patch.

        Show
        Claus Ibsen added a comment - Christian looks awesome. Can you attach the .jks files as individual files to this ticket as I got trouble extracting them from the patch.
        Hide
        Christian Müller added a comment -

        Hello Claus!

        I have done my work on this component - on time to Nicolaus...
        Maybe you could have a look on this patch. If you agree with this contribution, I will update the wiki page.

        Regards,
        Christian

        Show
        Christian Müller added a comment - Hello Claus! I have done my work on this component - on time to Nicolaus... Maybe you could have a look on this patch. If you agree with this contribution, I will update the wiki page. Regards, Christian
        Hide
        Claus Ibsen added a comment -

        Yeah good idea to refactor the FtpServerTestSupport so it supports FTP and FTPS tests.

        I have upgraded your JIRA account so you can assign tickets to yourself. I have assigned this to you.

        Show
        Claus Ibsen added a comment - Yeah good idea to refactor the FtpServerTestSupport so it supports FTP and FTPS tests. I have upgraded your JIRA account so you can assign tickets to yourself. I have assigned this to you.
        Hide
        Christian Müller added a comment -

        Hello Claus,

        ok I will do this.
        I think , I should also refactor the FtpServerTestSupport, so that we could reuse this for the secure FTP tests. The bad thing is, that we can not longer use the @BeforClass Annotation, because the subclasses has to provide the proper security configuration (we have to use the @Before Annotation). But I think it's ok, because most of the test cases contains only one test. What do you think?

        Regards,
        Christian

        Show
        Christian Müller added a comment - Hello Claus, ok I will do this. I think , I should also refactor the FtpServerTestSupport, so that we could reuse this for the secure FTP tests. The bad thing is, that we can not longer use the @BeforClass Annotation, because the subclasses has to provide the proper security configuration (we have to use the @Before Annotation). But I think it's ok, because most of the test cases contains only one test. What do you think? Regards, Christian
        Hide
        Claus Ibsen added a comment -

        Christian cool.

        At first though I would have thought we could reuse FTPComponent and just have additional configuration for SSL for the FTPClient so we could reuse the existing code.

        Maybe you could try to look into this approach as we then wont have to duplicate so much code.

        Show
        Claus Ibsen added a comment - Christian cool. At first though I would have thought we could reuse FTPComponent and just have additional configuration for SSL for the FTPClient so we could reuse the existing code. Maybe you could try to look into this approach as we then wont have to duplicate so much code.
        Hide
        Christian Müller added a comment -

        Hello Claus,

        I have done some development for this component (ca. 70%). Maybe do you have some advices for me?

        Regards,
        Christian

        Show
        Christian Müller added a comment - Hello Claus, I have done some development for this component (ca. 70%). Maybe do you have some advices for me? Regards, Christian
        Hide
        Claus Ibsen added a comment -

        FTPS is in commons net 2.0

        Show
        Claus Ibsen added a comment - FTPS is in commons net 2.0

          People

          • Assignee:
            Christian Müller
            Reporter:
            Claus Ibsen
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development