[CAMEL-17213] camel-sftp `maximumReconnectAttempts` property changed behaviour

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.13.0
• Fix Version/s: 3.14.0
• Component/s: camel-sftp
• Estimated Complexity: Unknown

Language

Java

• Assignee: Claus Ibsen
• Reporter: Mikołaj Matejko
• Created: 19/Nov/21 11:41
• Updated: 26/Nov/21 10:38
• Resolved: 26/Nov/21 10:38

Description

After upgrading from Camel 3.11.3 to Camel 3.13.0 we noticed that Camel cannot establish SFTP connection and throws an `org.apache.camel.component.file.GenericFileOperationFailedException: Cannot connect to` exception.

 

By diving into it we found out that the cause is `maximumReconnectAttempts` property which we had set to 0.

before Camel 3.13 -> maximumReconnectAttempts as the name says determined how many retries of connecting to sftp we should have (so setting it to 0 means we will try to connect once, and then we won’t try to reconnect in case of failure)
in Camel 3.13 -> maximumReconnectAttempts means how many connections to sftp we should have, so setting it to 0 means that we will never try to establish the connection 

To solve this for now we changed maximumReconnectAttempts to 1, however we noticed that SftpOperations.java was refactored and probably this bug was unintentionally introduced, as it doesn't seem as correct behavior.