[CAMEL-16079] aws-sn2 does not recognise FIFO queue configured though arn

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.7.0, 3.7.1, 3.7.2, 3.8.0
• Fix Version/s: 3.7.3, 3.9.0
• Component/s: camel-aws2

Environment

Likely any, but tested on a docker image of amazoncorretto:11

• Estimated Complexity: Novice
• Assignee: Andrea Cosentino
• Reporter: Aurore Weber
• Created: 25/Jan/21 15:46
• Updated: 11/Feb/21 08:23
• Resolved: 11/Feb/21 06:35

Description

When configuring an AWS SNS that is a fifo through the topic, the code that identify it as FIFO does not pick up the information, and so does not provide the provide the required attribute messageGroupId.

 

Issues is in file https://github.com/apache/camel/blob/master/components/camel-aws2-sns/src/main/java/org/apache/camel/component/aws2/sns/Sns2Configuration.java 

 

boolean isFifoTopic() {        
 return topicName.endsWith(".fifo");    
}

Likely this would fix it as the topicName is null, but the topicArn is not null whether it has been configured by topic or by arn : 

boolean isFifoTopic() { 
 return topicArn.endsWith(".fifo") ; 
}

Issue Links

• relates to: CAMEL-15806 Camel-AWS2-SNS: Support FIFO Topic
• links to: GitHub Pull Request #4928
• links to: GitHub Pull Request #5070