Uploaded image for project: 'Camel'
  1. Camel
  2. CAMEL-15770

Kafka serialize/deserialize properties are inconsistently named

    XMLWordPrintableJSON

    Details

    • Estimated Complexity:
      Novice

      Description

      There are 3 pairs of serializer/deserialiser properties on the Kafka component.

      The inconsistent parts of the names are highlighted

       

      Consumer Producer Type
      *kafka*HeaderDeserializer *kafka*HeaderSerializer Bean
      keyDeserializer keySerializer*Class* String FQN
      *value*Deserializer serializer*Class* String FQN

       

      I think it would be worth making these names consistent.

      Current Proposed
      kafkaHeaderDeserializer headerDeserializer
      kafkaHeaderSerializer headerSerializer
      keyDeserializer keyDeserializer
      keySerializerClass keySerializer
      valueDeserializer valueDeserializer
      serializerClass valueSerializer

      It looks like there was an intent to denote the key- and value- properties as expecting a class FQN string by appending 'Class' to the name. I don't see any other properties that do this so I think the consistent approach is to leave it off.

      I've made an assumption that valueDeserializer & serializerClass are a pair, as the descriptions don't match. It would be good to take the opportunity to make all six descriptions consistent.

        Attachments

          Activity

            People

            • Assignee:
              acosentino Andrea Cosentino
              Reporter:
              FrankyG Franky Georg
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: