[CAMEL-15568] Dynamic route updates causes few requests to fails

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 3.2.0
• Component/s: came-core
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Minal Bhalodi
• Created: 22/Sep/20 17:23
• Updated: 04/Apr/24 13:04
• Resolved: 22/Sep/20 19:22

Description

We are using Apache Camel 3.2.0. We update camel routes at runtime using below code. 

// update routes in camel contexts. Definitions are in XML files

ModelCamelContext mcc = camelContext.adapt(ModelCamelContext.class);
mcc.addRouteDefinitions(workflowDefinitionsList); // workflowDefinitionsList is the list of XML routes

 

Problem Statement: Dynamic routes updates causes few requests to fail at runtime. When these routes are being updated, we also call getRoute to serve live traffic.

Since addRouteDefinitions first delete routes given in workflowDefinitionsList from camel context and then add those routes back to camelcontext, These routes won't be available for few mili second and that causes request to fails.

Route route = exchange.getContext().getRoute(workflowRouteId);  // get route

Since there can be only one CamelContext per Application, I am not sure how can I resolve this issue. Is there any other method available where we can PATCH routes changes at runtime. Dynamic route updates shouldn't cause few requests to fails.

 

 

Here is camel 3 code for addRouteDefinitions method where routes are being removed and added:

public synchronized void addRouteDefinitions(Collection<RouteDefinition> routeDefinitions) throws Exception {
    if (routeDefinitions != null && !routeDefinitions.isEmpty()) {
        List<RouteDefinition> list = new ArrayList();
        routeDefinitions.forEach((r) -> {
            if (this.routeFilter == null || (Boolean)this.routeFilter.apply(r)) {
                list.add(r);
            }

        });
        this.removeRouteDefinitions(list);
        this.routeDefinitions.addAll(list);
        if (this.shouldStartRoutes()) {
            ((ModelCamelContext)this.getCamelContext().adapt(ModelCamelContext.class)).startRouteDefinitions(list);
        }

    }
}

 

 

We are not able to updates routes in camelcontext frequently because of this issue. Everytime we update routes in camelcontext that causes us some FCI since we have high traffic in our application.