[CAMEL-15316] Camel Zipkin does not set correct span kind

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.1
• Fix Version/s: 3.4.3, 3.5.0
• Component/s: camel-zipkin
• Estimated Complexity: Unknown
• Assignee: Andrea Cosentino
• Reporter: Samrat Dhillon
• Created: 20/Jul/20 18:01
• Updated: 21/Jul/20 16:12
• Resolved: 21/Jul/20 16:12

Description

Camel Zipkin does not set correct span kind for components such as jms, kafka, amqp etc. For these components the Span kind should be either Consumer or Producer. However camel zipkin sets Server or Client span kind for all components. 

This is not just a cosmetic issue as the span kind determines what tracing headers are injected by brave library. E.g. Span kind Producer will inject b3 header which is comes from brave.propagation.B3SingleFormat.writeB3SingleFormatWithoutParentId(TraceContext). In case of JMS this becomes important for co-relation to work with a non camel application as X-B3-TraceId, X-B3-SpanId, X-B3-ParentSpanId & X-B3-Spampled are not valid JMS headers. Camel escapes the hyphens when these headers are written as JMS messages, but this is a non standard implementation. For co-relation to work using brave, these headers have to be written using b3 single format and this is determine by Span Kind.

Issue Links

• links to: GitHub Pull Request #4026