[CAMEL-13886] camel-servlet + camel-http4 with null body causes "Stream closed" IOException

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0.M4, 2.25.0
• Fix Version/s: 3.0.0.RC2, 2.25.0
• Component/s: camel-http-common, camel-http4, camel-servlet
• Estimated Complexity: Unknown
• Assignee: Tadayoshi Sato
• Reporter: Tadayoshi Sato
• Created: 21/Aug/19 06:05
• Updated: 13/Sep/19 09:31
• Resolved: 13/Sep/19 02:37

Description

A Rest DSL route like the following causes java.io.IOException: Stream closed when invoked at http://localhost:8000/test/proxy:

        rest("/test")
                .get("/proxy")
                .to("direct:callInternalRestService");

        from("direct:callInternalRestService")
                .setHeader(Exchange.HTTP_METHOD, constant("DELETE"))
                //.setBody(constant("")) // workaround for null body and http4 component
                .to("http4://localhost:9000/test?bridgeEndpoint=true")
                .log("${body}");

The error stacktrace:

Caused by: java.io.IOException: Stream closed
	at org.apache.catalina.connector.InputBuffer.read(InputBuffer.java:372)
	at org.apache.catalina.connector.CoyoteInputStream.read(CoyoteInputStream.java:156)
	at org.apache.camel.util.IOHelper.copy(IOHelper.java:202)
	at org.apache.camel.util.IOHelper.copy(IOHelper.java:174)
	at org.apache.camel.util.IOHelper.copyAndCloseInput(IOHelper.java:234)
	at org.apache.camel.util.IOHelper.copyAndCloseInput(IOHelper.java:230)
	at org.apache.camel.http.common.HttpHelper.readResponseBodyFromInputStream(HttpHelper.java:245)
	at org.apache.camel.http.common.HttpHelper.readRequestBodyFromServletRequest(HttpHelper.java:196)
	at org.apache.camel.http.common.DefaultHttpBinding.parseBody(DefaultHttpBinding.java:577)
	at org.apache.camel.http.common.HttpMessage.createBody(HttpMessage.java:78)
	... 54 common frames omitted

This seems to happen only when Tomcat is used as the container with Spring Boot. Undertow doesn't cause such an issue.

The real root cause is that when an exchange has an HttpMessage with null body as its out message, then the next time Exchange.getMessage() is invoked the HttpMessage is tricked by the null body and tries to create body again with the already closed request input stream.

Issue Links

• links to: GitHub Pull Request #3166