[CAMEL-13527] Implement missing optimisation for DelimiterBasedFrameDecoder

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.24.0, 3.0.0-M2
• Fix Version/s: 3.0.0-M3, 2.23.3, 2.22.5, 2.24.1, 3.0.0, 2.25.0
• Component/s: camel-netty4
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Jan Bednar
• Created: 15/May/19 19:48
• Updated: 16/May/19 03:07
• Resolved: 16/May/19 03:07

Description

See pretty nice analysis on SO https://stackoverflow.com/questions/56110408/memory-leak-in-camel-netty-tcp-client-when-consuming-lines-with-windows-line-bre

io.netty.handler.codec.DelimiterBasedFrameDecoder internally delegates decoding to io.netty.handler.codec.LineBasedFrameDecoder. This delegation is not working with Camel, because Netty internally checks for condition

this.getClass() != DelimiterBasedFrameDecoder.class // io.netty.handler.codec.DelimiterBasedFrameDecoder line 174 - !isSubclass()

We can recreate similar optimisation inside org.apache.camel.component.netty4.codec.DelimiterBasedFrameDecoder and get (according to SO post) significant performance improvement.

Issue Links

• links to: GitHub Pull Request #2921