Uploaded image for project: 'Camel'
  1. Camel
  2. CAMEL-13341

camel-linkedin: If accessToken is set, other credentials should be unnecessary

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-M2, 3.0.0
    • Component/s: camel-linkedin
    • Labels:
      None
    • Estimated Complexity:
      Unknown

      Description

      If you run camel-linkedin quickstart, it is possible to fill accessToken into configuration and with it, all other authentication parameters (userName, userPassword, clientId, clientSecret) are ignored, but can not be empty.

      For example this configuration works:

      <bean id="linkedinConfiguration" class="org.apache.camel.component.linkedin.LinkedInConfiguration">
      	<property name="clientId" value="null"/>
      	<property name="clientSecret" value="null"/>
      	<property name="redirectUri" value="https://localhost"/>
      	<property name="userName" value="null"/>
      	<property name="userPassword" value="null"/>
      	<property name="accessToken" value="very long but correct access token"/>
      </bean>

      But following configuration should work too (because no real value is removed from the first one):

      <bean id="linkedinConfiguration" class="org.apache.camel.component.linkedin.LinkedInConfiguration">
      	<property name="redirectUri" value="https://localhost"/>
      	<property name="accessToken" value="very long but correct access token"/>
      </bean>

      It should be possible to improve component a little bit to allow empty authentication parameters in case of filled accessToken.
      (other possible solution is to forbid accessToken functionality, but it will change back-compatibility and possibly harm some users)

      But it should not be allowed to have filled accessToken and also authentication credential, because it will be misleading (for example accessToken could be created for different user)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                acosentino Andrea Cosentino
                Reporter:
                jondruse Jiri Ondrusek
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m