Camel
  1. Camel
  2. CAMEL-1278

VelocityEndpoint reads velocity templates using default encoding - add parameter to set encoding

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.0
    • Fix Version/s: 1.6.0, 2.0-M1
    • Component/s: camel-velocity
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      VelocityEndpoints reads templates using default encoding, so I cannot get correct content while running on Windows and Linux.

      The reason is that there is used InputStreamReader constructor without encoding parameter.

      I've added simple support for setting encoding - see attached patch

        Activity

        Damian Golda created issue -
        Hide
        Damian Golda added a comment -

        Patch to VelocityEndpoint.java

        Show
        Damian Golda added a comment - Patch to VelocityEndpoint.java
        Damian Golda made changes -
        Field Original Value New Value
        Attachment VelocityEndpoint.diff [ 17533 ]
        Jonathan Anstey made changes -
        Assignee Jonathan Anstey [ janstey ]
        Jonathan Anstey <janstey@apache.org> committed 3a749f495f0ffacdb99cb0a890e7e554014856f6 (3 files)
        Reviews: none

        Merged revisions 736046 via svnmerge from https://svn.apache.org/repos/asf/camel/trunk
        ........
          r736046 | janstey | 2009-01-20 14:13:25 -0330 (Tue, 20 Jan 2009) | 3 lines
          
          CAMEL-1278 - Adding option to set encoding for velocity template. Thanks to Damian for the patch!
        ........


        git-svn-id: https://svn.apache.org/repos/asf/camel/branches/camel-1.x@736047 13f79535-47bb-0310-9956-ffa450edef68

        Jonathan Anstey committed 736047 (4 files)
        Hide
        Jonathan Anstey added a comment -

        I've committed your changes in revision 736046. Thanks for the contribution Damian! I also added a little unit test for this new option.

        Show
        Jonathan Anstey added a comment - I've committed your changes in revision 736046. Thanks for the contribution Damian! I also added a little unit test for this new option.
        Hide
        Jonathan Anstey added a comment -
        Show
        Jonathan Anstey added a comment - Updated the wiki here as well http://cwiki.apache.org/confluence/display/CAMEL/Velocity
        Jonathan Anstey made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0.0 [ 11900 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 1.5.1 [ 11991 ]
        Hide
        Claus Ibsen added a comment -

        Remember to update the wiki

        Show
        Claus Ibsen added a comment - Remember to update the wiki
        Hide
        Jonathan Anstey added a comment -

        Haha! Beat you to it, wiki police

        Show
        Jonathan Anstey added a comment - Haha! Beat you to it, wiki police
        Hide
        Damian Golda added a comment -

        Jonathan, thank you for very quick action. I'm impressed.

        Show
        Damian Golda added a comment - Jonathan, thank you for very quick action. I'm impressed.
        Hadrian Zbarcea made changes -
        Fix Version/s 2.0.0 [ 11900 ]
        Fix Version/s 2.0-M1 [ 12061 ]
        Fix Version/s 1.6.0 [ 11991 ]
        Jeff Turner made changes -
        Fix Version/s 1.6.0 [ 11991 ]
        Hide
        Claus Ibsen added a comment -

        Closing 2.0m1 tickets

        Show
        Claus Ibsen added a comment - Closing 2.0m1 tickets
        Claus Ibsen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Jeff Turner made changes -
        Project Import Sat Nov 27 00:14:50 EST 2010 [ 1290834890113 ]

          People

          • Assignee:
            Jonathan Anstey
            Reporter:
            Damian Golda
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development