[CAMEL-12724] Simple SFTP-to-File integration with charset options fails

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.22.0
• Fix Version/s: 2.21.3, 2.22.1, 2.23.0
• Component/s: camel-core, camel-ftp
• Estimated Complexity: Unknown
• Assignee: Tadayoshi Sato
• Reporter: Tadayoshi Sato
• Created: 10/Aug/18 07:21
• Updated: 25/Aug/21 10:34
• Resolved: 10/Aug/18 07:46

Description

Simple SFTP-to-File integrations with charset conversion like:

from("sftp://sample@localhost:2222/in?password=password&delete=true&charset=ISO-8859-1")
    .to("file:/tmp/samples-camel/SftpToFileTest/out?charset=UTF-8");

fails to output a file in /tmp/samples-camel/SftpToFileTest/out/ correctly. Depending on the combinations, it sometimes converts the charset wrongly and sometimes it simply doesn't output a file to the target dir.

The root cause is that SftpOperations puts ByteArrayOutputStream instead of byte[] or InputStream to the exchange file body when retrieving a file:
https://github.com/apache/camel/blob/camel-2.22.0/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java#L718-L720
which then results in no converter from OutputStream to java.io.Reader being found in GenericFileConverter downstream, and thus the File producer handles a RemoteFile awkwardly when outputting a file.

Issue Links

• links to: GitHub Pull Request #2463