Details
-
Task
-
Status: Resolved
-
Major
-
Resolution: Not A Problem
-
None
-
None
-
Novice
Description
We got some errors reported
[INFO] --- maven-checkstyle-plugin:3.0.0:checkstyle (default-cli) @ camel-core --- [INFO] Starting audit... [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/util/GroupTokenIteratorTest.java:22:1: Redundant import from the same package - org.apache.camel.util.Scanner. [RedundantImport] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/util/GroupTokenIteratorTest.java:24: Wrong order for 'org.apache.camel.CamelContext' import. [ImportOrder] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/impl/FileStateRepository.java:25: Wrong order for 'java.util.concurrent.atomic.AtomicBoolean' import. [ImportOrder] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/converter/jaxp/XmlConverter.java:95:39: Name 'domLoggingErrorHandler' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/util/SkipIterator.java:22:1: Redundant import from the same package - org.apache.camel.util.Scanner. [RedundantImport] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/util/SkipIterator.java:23: Wrong order for 'java.util.concurrent.atomic.AtomicBoolean' import. [ImportOrder] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/util/Scanner.java:58:21: Variable 'inputExhausted' explicitly initialized to 'false' (default value for its type). [ExplicitInitialization] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/util/Scanner.java:59:21: Variable 'needInput' explicitly initialized to 'false' (default value for its type). [ExplicitInitialization] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/util/Scanner.java:60:21: Variable 'skipped' explicitly initialized to 'false' (default value for its type). [ExplicitInitialization] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/util/Scanner.java:62:21: Variable 'closed' explicitly initialized to 'false' (default value for its type). [ExplicitInitialization] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/util/Scanner.java:197:14: Unnecessary parentheses around identifier 'inputExhausted'. [UnnecessaryParentheses] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/util/IntrospectionSupport.java:136:22: Name 'CACHE' must match pattern '^[a-z][a-zA-Z0-9]*$'. [LocalVariableName] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/util/GroupTokenIterator.java:24:1: Redundant import from the same package - org.apache.camel.util.Scanner. [RedundantImport] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/util/GroupTokenIterator.java:25: Wrong order for 'java.util.concurrent.atomic.AtomicBoolean' import. [ImportOrder] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/processor/idempotent/FileIdempotentRepository.java:26: Wrong order for 'java.util.concurrent.atomic.AtomicBoolean' import. [ImportOrder] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/processor/Splitter.java:27: Wrong order for 'java.util.concurrent.ExecutorService' import. [ImportOrder] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/support/TokenPairExpressionIterator.java:25: Wrong order for 'org.apache.camel.Exchange' import. [ImportOrder] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/support/TokenXMLPairExpressionIterator.java:24: Wrong order for 'java.util.regex.Matcher' import. [ImportOrder] [ERROR] /Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/builder/ExpressionBuilder.java:31: Wrong order for 'java.util.Set' import. [ImportOrder] Audit done. [INFO] There are 19 errors reported by Checkstyle 7.6.1 with camel-checkstyle.xml ruleset.
You can run this via camel-core
/camel/camel-core (master)/$ mvn compile -P sourcecheck