[CAMEL-12659] MllpTcpServerConsumer logging failure to set HL7 headers even when setting HL7 headers is disabled

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.20.3, 2.21.1, 2.22.0
• Fix Version/s: 2.20.4, 2.21.2, 2.22.1, 2.23.0
• Component/s: camel-mllp
• Estimated Complexity: Novice
• Assignee: Quinn Stevenson
• Reporter: Quinn Stevenson
• Created: 17/Jul/18 13:25
• Updated: 17/Jul/18 19:50
• Resolved: 17/Jul/18 19:50

Description

In the process of setting Camel message headers from the payload, the MllpTcpServerConsumer is logging an error when it fails to identify the MSH segment of the message.  This error is logged before the hl7Headers configuration option is checked, so the error is always logged - even if setting the HL7 headers is disabled (i.e. hl7Headers=false).

This is a minor issue, but it effects edge cases where non-HL7 payloads are sent with the MLLP protocol.

The logic should be changed such that if the hl7Headers option is false, don't do anything (i.e. no log statement).