[CAMEL-12394] Camel Bindy: marshal doesn't quote headers

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.20.2
• Fix Version/s: 2.20.3, 2.21.1, 2.22.0
• Component/s: camel-bindy

Environment

Windows 7

• Patch Info: Patch Available
• Estimated Complexity: Moderate
• Flags: Patch
• Assignee: Claus Ibsen
• Reporter: Clemens Blamauer
• Created: 22/Mar/18 17:28
• Updated: 23/Mar/18 09:34
• Resolved: 23/Mar/18 09:34

Description

Dear all,

When marshaling, Bindy doesn't quote headers in CSV files. This is problematic in the case where headers contain the separator character. When unmarshaling this is no issue, as `skipFirstLine=true`.

Unfortunately, changing the header is not an option in my case.

Please find attached:

• A sample CsvRecord-annotated bean `WickedCsv.java`, and
• a JUnit test `WickedCsvTest.java`
  which allow to reproduce the issue.

The assertion error occurs in the last line of the `test()` method:
`assertEquals(csv.trim(), result.trim())`

I have attached a patch for BindyCsvFactory (`BindyCsvFactory.patch`), which fixes the issue. I copied and adjusted the lines according to the quote handling in `org.apache.camel.dataformat.bindy.BindyCsvFactory#bind`.

Would you please check?

Thank you.

Kind regards,
Clemens