[CAMEL-12123] camel-salesforce - Http proxy support uses two inconsistent methods and is broken

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.20.1
• Fix Version/s: 2.21.0
• Component/s: camel-salesforce
• Labels: proxy salesforce
• Estimated Complexity: Unknown
• Regression: Regression
• Assignee: Zoran Regvart
• Reporter: Mabrouk Belhout
• Created: 04/Jan/18 14:32
• Updated: 27/Feb/18 13:38
• Resolved: 27/Feb/18 13:38

Description

in the SalesforceComponent class, there is two ways to configure a http proxy :

• using setHttpProxyHost method and others alike
• using httpClientProperties map with proxy keys (HTTP_PROXY_HOST and others ...)

but instance variables set by setHttpProxyXXX methods are not used and should be considered as dead code.
one can have a look at the setupHttpClient() method to figure out that the proxy variables are not used, but only the properties map is.

This bug was discovered while proceeding to an upgrade from 2.19.x to 2.20.1.