[CAMEL-12109] camel-zipkin - Generate tracing identifiers on exchange begin if they do not exist

• Type: New Feature
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.23.0
• Component/s: camel-zipkin
• Estimated Complexity: Unknown
• Assignee: Ramu
• Reporter: Chris Snyder
• Created: 02/Jan/18 15:10
• Updated: 28/Aug/18 10:02
• Resolved: 28/Aug/18 10:02

Description

The current Zipkin instrumentation generates tracing IDs during client requests (in com.github.kristofa.brave.ClientTracer.startNewSpan()). However, it does not do so for server requests (see ZipkinTracer.ZipkinRoutePolicy.onExchangeBegin()). This means that if the client does not supply its own tracing headers, nothing will be traced until a client request is made from within Camel.

This can be demonstrated using the camel-example-zipkin modules by removing the Zipkin instrumentation from the client module. When this is done, the service1 module will not report any spans.

The Zipkin documentation indicates that tracing information should be generated when none is present: "When an incoming request has no trace information attached, we generate a random trace ID and span ID."

Issue Links

• links to: GitHub Pull Request #2494