[CAMEL-11671] camel-ahc - No way to disable url encoding - ASF JIRA

Voters

Watch issue

Watchers

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.19.1
Fix Version/s: 2.19.3, 2.20.0
Component/s: camel-ahc
Labels:
None

Estimated Complexity:
Novice

Description

There currently seems to be now way to really disable url encoding for ahc urls with query parameters.

I even tried to use my own ahc binding.
The problem seems to be, that the AhcProducer uses this section:

 public boolean process(Exchange exchange, AsyncCallback callback) {
        try {
            // AHC supports async processing
            Request request = getEndpoint().getBinding().prepareRequest(getEndpoint(), exchange);
            log.debug("Executing request {} ", request);
            client.prepareRequest(request).execute(new AhcAsyncHandler(exchange, callback, request.getUrl(), getEndpoint().getBufferSize()));
            return false;
        } catch (Exception e) {
            exchange.setException(e);
            callback.done(true);
            return true;
        }
    }

By calling client.prepareRequest(request) the already created request will be turned again into a request builder with enabled url encoding.
From my perspective this makes no sense:

we could already return a request builder from the AhcBinding, which would save us some processing time
the settings on this request builder would then not be overriden

But I can see this would be a breaking change in the API of the AhcBinding.