[CAMEL-11609] camel-univocity-parsers: marshaller not thread safe

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.19.1
• Fix Version/s: 2.20.0
• Component/s: camel-csv
• Estimated Complexity: Unknown
• Assignee: Andrea Cosentino
• Reporter: Daniel Baldes
• Created: 27/Jul/17 08:15
• Updated: 01/Aug/17 13:02
• Resolved: 01/Aug/17 11:33

Description

org.apache.camel.dataformat.univocity.Marshaller.java is not thread safe.

When this.adaptheaders is true, this.headers is modified in the wirteRow() method. This can lead to ConcurrentModificationExceptions (see below) and jumbled headers, occasionally.

I use a UnivocityCsvDataFormat for marshalling CSV in a route which is called in parallel. The DataFormat creates a Marshaller with adaptheaders == true when headers are not specified in the format.

java.util.ConcurrentModificationException: null
            at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
            at java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:742)
            at org.apache.camel.dataformat.univocity.Marshaller.writeRow(Marshaller.java:95)
            at org.apache.camel.dataformat.univocity.Marshaller.marshal(Marshaller.java:67)
            at org.apache.camel.dataformat.univocity.AbstractUniVocityDataFormat.marshal(AbstractUniVocityDataFormat.java:94)
            at org.apache.camel.processor.MarshalProcessor.process(MarshalProcessor.java:69)
            at org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)
            at org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
            at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
            at org.apache.camel.processor.Pipeline.process(Pipeline.java:120)
            at org.apache.camel.processor.Pipeline.process(Pipeline.java:83)
            at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
            at org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:62)
            at org.apache.camel.processor.SendDynamicProcessor$1.doInAsyncProducer(SendDynamicProcessor.java:124)
            at org.apache.camel.impl.ProducerCache.doInAsyncProducer(ProducerCache.java:436)
            at org.apache.camel.processor.SendDynamicProcessor.process(SendDynamicProcessor.java:119)
            at org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
            at org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
            at org.apache.camel.processor.DelegateAsyncProcessor.process(DelegateAsyncProcessor.java:97)
            at org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:137)
            at org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:133)
            at java.util.concurrent.FutureTask.run(FutureTask.java:266)
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
            at java.lang.Thread.run(Thread.java:748)

Issue Links

• links to: GitHub Pull Request #1855
• links to: GitHub Pull Request #1859