[CAMEL-11212] Don't allow Salesforce HTTP client to stop with outstanding requests

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.19.0
• Component/s: camel-salesforce
• Estimated Complexity: Unknown
• Assignee: Zoran Regvart
• Reporter: Zoran Regvart
• Created: 27/Apr/17 12:34
• Updated: 08/Jun/17 13:04
• Resolved: 28/Apr/17 16:01

Description

The Salesforce component uses Jetty asynchronous client throughout. There is a race condition that might occur if the component's HTTP client is stopped while one or more requests are still in progress. The result of which could be inconsistencies in execution.
This was seen in the implementation of the connectivity validation in the ping check which creates the SalesforceHttpClient and DefaultRestClient and starts/stops then in a small time frame.

Issue Links

• relates to: CAMEL-11386 Potential NullPointerException if HTTP client not started and stop was performed
• links to: GitHub Pull Request #1666