[CAMEL-11009] Camel spring - spring.schemas file contains unexpaned maven properties in release artefact

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.18.0, 2.18.1, 2.18.2
• Fix Version/s: 2.18.4, 2.19.0
• Component/s: camel-spring

Environment

any

• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Niels Bertram
• Created: 14/Mar/17 04:43
• Updated: 19/Mar/17 15:32
• Resolved: 18/Mar/17 08:57

Description

Looking at http://search.maven.org/remotecontent?filepath=org/apache/camel/camel-spring/2.18.2/camel-spring-2.18.2.jar

I can see that file /META-INF/spring.schemas shows non-expanded maven property v${camel.schema.version} in the file. This causes loading a route in Karaf fail.

#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements.  See the NOTICE file distributed with
...
http\://camel.apache.org/schema/spring=camel-spring.xsd
http\://camel.apache.org/schema/spring/v${camel.schema.version}=camel-spring-v${camel.schema.version}.xsd

Ok in 2.17.x and 2.16.x but broken in 2.18.x releases.

Stack trace from running a camel route in Karaf with camel-spring-2.18.2 installed:

2017-03-12 23:00:39,527 | WARN  | pool-32-thread-2 | NamespaceHandlerRegistryImpl     | 12 - org.apache.aries.blueprint.core - 1.7.1 | Error registering NamespaceHandler
java.lang.IllegalArgumentException: Illegal character in path at index 40: http://camel.apache.org/schema/spring/v${camel.schema.version}
        at java.net.URI.create(URI.java:852) [?:?]
        at org.apache.aries.blueprint.namespace.NamespaceHandlerRegistryImpl.getNamespaces(NamespaceHandlerRegistryImpl.java:203) [12:org.apache.aries.blueprint.core:1.7.1]
        at org.apache.aries.blueprint.namespace.NamespaceHandlerRegistryImpl.registerHandler(NamespaceHandlerRegistryImpl.java:157) [12:org.apache.aries.blueprint.core:1.7.1]
        at org.apache.aries.blueprint.namespace.NamespaceHandlerRegistryImpl.addingService(NamespaceHandlerRegistryImpl.java:121) [12:org.apache.aries.blueprint.core:1.7.1]
        at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:941) [?:?]
        at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:870) [?:?]
        at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256) [?:?]
        at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229) [?:?]
        at org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:901) [?:?]
        at org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990) [?:?]
        at org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838) [?:?]
        at org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545) [?:?]
        at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4557) [?:?]
        at org.apache.felix.framework.Felix.registerService(Felix.java:3549) [?:?]
        at org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:348) [?:?]
        at org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:355) [?:?]
        at org.apache.aries.blueprint.spring.SpringExtension.start(SpringExtension.java:78) [202:org.apache.aries.blueprint.spring:0.2.0]
        at org.apache.felix.utils.extender.AbstractExtender$1.run(AbstractExtender.java:265) [202:org.apache.aries.blueprint.spring:0.2.0]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) [?:?]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) [?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:?]
        at java.lang.Thread.run(Thread.java:745) [?:?]
Caused by: java.net.URISyntaxException: Illegal character in path at index 40: http://camel.apache.org/schema/spring/v${camel.schema.version}
        at java.net.URI$Parser.fail(URI.java:2848) ~[?:?]
        at java.net.URI$Parser.checkChars(URI.java:3021) ~[?:?]
        at java.net.URI$Parser.parseHierarchical(URI.java:3105) ~[?:?]
        at java.net.URI$Parser.parse(URI.java:3053) ~[?:?]
        at java.net.URI.<init>(URI.java:588) ~[?:?]
        at java.net.URI.create(URI.java:850) ~[?:?]
        ... 24 more

Issue Links

• links to: GitHub Pull Request #1548