Uploaded image for project: 'Camel'
  1. Camel
  2. CAMEL-10713

SCP not handling errors for failed transfers correctly

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.17.6, 2.18.2, 2.19.0
    • Component/s: camel-jsch
    • Labels:
      None
    • Estimated Complexity:
      Unknown

      Description

      If I try to transfer a file to a directory that does not exist using Camel SCP I see a warning like this in the log:

      [scp] WARN scp: /home/user/scp/1234: No such file or directory
      It looks like the code says that Camel will just log a warning when such an error occurs. There is no exception in the code, so it looks like the file was transferred when it was not.

      https://github.com/apache/camel/blob/52a739feb9da8acd29067304c7c8356bbc5ef4dd/components/camel-jsch/src/main/java/org/apache/camel/component/scp/ScpOperations.java#L347

      The error codes for SCP are:

      1 General error in file copy
      2 Destination is not directory, but it should be

      http://support.attachmate.com/techdocs/2116.html

      The fix should have the SCP Endpoint raise an error if the return code is not 0.

      See the following discussion.

      http://camel.465427.n5.nabble.com/Camel-SCP-Warnings-td5792552.html

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                davsclaus Claus Ibsen
                Reporter:
                patrickmcgloin Patrick McGloin
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: