[CAMEL-10411] Camel-Blueprint - failed container gets restarted automatically

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.18.0
• Fix Version/s: 2.17.4, 2.18.1, 2.19.0
• Component/s: camel-blueprint
• Patch Info: Patch Available
• Estimated Complexity: Unknown
• External issue URL: https://issues.jboss.org/browse/ENTESB-6174
• Assignee: Andrea Cosentino
• Reporter: Paolo Antinori
• Created: 24/Oct/16 15:30
• Updated: 25/Oct/16 06:49
• Resolved: 25/Oct/16 06:49

Description

In case of a wrong endpoint definition, a CamelContext could be automatically restarted even if the start operation was correctly aborted.

This happens because during BlueprintCamelContext, the CamelContext instance is registered as a ServiceListener

https://github.com/apache/camel/blob/master/components/camel-blueprint/src/main/java/org/apache/camel/blueprint/BlueprintCamelContext.java#L102

Due to that reason, even after a stop() call is invoked by the error execution branch of start(), that instance is receptive to external service events that result in the invocation of this method:

https://github.com/apache/camel/blob/master/components/camel-blueprint/src/main/java/org/apache/camel/blueprint/BlueprintCamelContext.java#L155

That method has the freedom to start again the CamelContext instance.

The proposed solution is to use a BlueprintCamelContext local flag to keep track of the successful initialization of the Context, to be able to ignore events in case activation wasn't successful.

Note that the BlueprintCamelContext instance, un-registers itself as a service listener, only in its destroy() method.

Attached to JBoss-Fuse linked case, there is a reproducer that shows the issue.

Issue Links

• links to: GitHub Pull Request #1221