[CAMEL-10347] Camel-scr todos and polish

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.18.0
• Component/s: camel-scr
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Jyrki Ruuskanen
• Created: 27/Sep/16 09:06
• Updated: 29/Sep/16 07:35
• Resolved: 29/Sep/16 07:25

Description

Visibility / access:

• Make context private. Use getter.
• Get rid of registry member variable. Get registry through context when needed.
• Make methods that are not supposed to be overriden final.

Customization:

• User can customize context's registry by overriding createRegistry() methods. Returns SimpleRegistry by default.
• Remove hardcoded defaults from setupCamelContext().

Corrections:

• Do not explicitly create an OsgiServiceRegistry for OsgiDefaultCamelContext. The context will create one anyway and combine it with whatever createRegistry(BundleContext) returns in a CompositeRegistry.
• Make camel-archetype-scr integration test run with Maven 3.3.9.

Issue Links

• links to: GitHub Pull Request #1188