Uploaded image for project: 'Camel'
  1. Camel
  2. CAMEL-10273

[Jetty] missing jmx object if custom thread pool is used

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.17.3
    • Fix Version/s: 2.17.4, 2.18.0
    • Component/s: camel-jetty
    • Labels:
      None

      Description

      If a custom configuration for the ThreadPool is passed, the correspondent JMX object is not published.

      The issue here is that enableJmx(), https://github.com/apache/camel/blob/camel-2.17.3/components/camel-jetty-common/src/main/java/org/apache/camel/component/jetty/JettyHttpComponent.java#L314

      that adds the mbeans listeners is called only after setThread https://github.com/apache/camel/blob/camel-2.17.3/components/camel-jetty-common/src/main/java/org/apache/camel/component/jetty/JettyHttpComponent.java#L1177 method, so this explains how come the threadpool is not exposed on JMX.

      I've put a simple PR that just adds a check for enableJmx flag at component level, but I wonder if I should make it smarter to take in account possible settings only at Endpoint level or instead if we should remove it the flag per Endpoint altogether.

        Attachments

          Activity

            People

            • Assignee:
              davsclaus Claus Ibsen
              Reporter:
              paolo.antinori Paolo Antinori

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment