[CAMEL-10240] CamelHttpClient default pool size does not work on system with large number of cpus

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.17.2
• Fix Version/s: 2.17.4, 2.18.0
• Component/s: camel-jetty
• Estimated Complexity: Novice
• Assignee: Claus Ibsen
• Reporter: Zoltan Farkas
• Created: 11/Aug/16 20:22
• Updated: 07/Sep/16 07:46
• Resolved: 07/Sep/16 07:46

Description

In CamelHttpClient a default threadpool is being created with a hardcoded size of 16:

    @Override
    protected void doStart() throws Exception {
        if (!hasThreadPool()) {
            // if there is no thread pool then create a default thread pool using daemon threads
            QueuedThreadPool qtp = new QueuedThreadPool();
            // 16 max threads is the default in the http client
            qtp.setMaxThreads(16);
            qtp.setDaemon(true);
            // let the thread names indicate they are from the client
            qtp.setName("CamelJettyClient(" + ObjectHelper.getIdentityHashCode(this) + ")");
            setThreadPoolOrExecutor(qtp);
        }
        super.doStart();
    }

this configuration does not work because number of selectors is calculated relative to the number of CPUs in HttpClientTransportOverHTTP:

   public HttpClientTransportOverHTTP()
    {
        this(Math.max(1, Runtime.getRuntime().availableProcessors() / 2));
    }

As a result by default camel simply hangs on these systems...

It would be nice if CamelHttpClient would have a constructor that set the HttpClientTransport or at least the number of selectors.

Issue Links

• links to: GitHub Pull Request #1157