[CAMEL-10165] DefaultCxfMessageMapper.getBasePath creates a incorrect http path

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.17.2
• Fix Version/s: 2.19.5, 2.20.2, 2.21.0
• Component/s: camel-cxf
• Estimated Complexity: Unknown
• Assignee: Claus Ibsen
• Reporter: Zoltan Farkas
• Created: 20/Jul/16 19:47
• Updated: 11/Jan/18 14:25
• Resolved: 11/Jan/18 14:25

Description

in DefaultCxfMessageMapper.java:

    protected String getBasePath(Exchange camelExchange) {
        String answer = camelExchange.getIn().getHeader(Exchange.HTTP_BASE_URI, String.class);
        if (answer == null) {
            answer = camelExchange.getFromEndpoint().getEndpointUri();
        }        
        return answer;
    }

camelExchange.getFromEndpoint().getEndpointUri()

in 2.14 returns a valid http URL for the jetty endpoint...]

meanwhile in 2.17 it return a camel url that includes the scheme and it breaks the semantics of this method. I had to change the method to:

    protected String getBasePath(Exchange camelExchange) {
        String answer = camelExchange.getIn().getHeader(Exchange.HTTP_BASE_URI, String.class);

        if (answer == null) {
            Endpoint fromEndpoint = camelExchange.getFromEndpoint();
            if (fromEndpoint instanceof HttpCommonEndpoint) {
              try {
                URI u = ((HttpCommonEndpoint) fromEndpoint). getHttpUri();
                answer = new URI(u.getScheme(), u.getUserInfo(), u.getHost(), u.getPort(), u.getPath(),
                        null, null).toString();
              } catch (URISyntaxException ex) {
                throw new RuntimeException(ex);
              }
            } else {
              return null;
            }
        }

        return answer;
    }

I am not sure this is the best way to deal with this, but it works...