[CALCITE-983] NPE in ErrorResponse construction

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: avatica
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 18/Nov/15 21:33
• Updated: 21/Jan/16 22:20
• Resolved: 04/Dec/15 02:12

Description

Noticed today:

2015-11-18 19:44:29,314 WARN org.eclipse.jetty.server.HttpChannel: /
java.lang.NullPointerException
        at org.apache.calcite.avatica.proto.Responses$ErrorResponse$Builder.setErrorMessage(Responses.java:7180)
        at org.apache.calcite.avatica.remote.Service$ErrorResponse.serialize(Service.java:2574)
        at org.apache.calcite.avatica.remote.Service$ErrorResponse.serialize(Service.java:2495)
        at org.apache.calcite.avatica.remote.ProtobufTranslationImpl.serializeResponse(ProtobufTranslationImpl.java:195)
        at org.apache.calcite.avatica.remote.ProtobufHandler.encode(ProtobufHandler.java:46)
        at org.apache.calcite.avatica.remote.ProtobufHandler.encode(ProtobufHandler.java:28)
        at org.apache.calcite.avatica.remote.AbstractHandler.apply(AbstractHandler.java:106)
        at org.apache.calcite.avatica.remote.ProtobufHandler.apply(ProtobufHandler.java:38)
        at org.apache.calcite.avatica.server.AvaticaProtobufHandler.handle(AvaticaProtobufHandler.java:63)
        at org.eclipse.jetty.server.handler.HandlerList.handle(HandlerList.java:52)
        at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
        at org.eclipse.jetty.server.Server.handle(Server.java:497)
        at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:310)
        at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:245)
        at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540)
        at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
        at java.lang.Thread.run(Thread.java:745)

Looks like we expected something to be non-null at this point, but didn't cover all avenues.