Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-765

RPC server returns JSON data with Content-Type set to text/html

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.0-incubating
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None
    • Flags:
      Patch

      Description

      The server currently always sets Content-Type to text/html, even though it's actually returning JSON data. That makes it hard to distinguish JSON response from a Jetty-generated error page. I suggest changing it to application/json (RFC 4627). I'm experimenting with writing a Python client for the RPC and I'd like to generate better exceptions than "something failed". How to handle error in the RPC is a discussion for another ticket, but this seems like the first obvious step.

        Activity

        Show
        lukaslalinsky Lukas Lalinsky added a comment - https://github.com/apache/incubator-calcite/pull/96
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/d559bacf . Thanks Lukas!
        Hide
        jnadeau Jacques Nadeau added a comment -

        Resolved in release 1.4.0-incubating (2015-08-23)

        Show
        jnadeau Jacques Nadeau added a comment - Resolved in release 1.4.0-incubating (2015-08-23)

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            lukaslalinsky Lukas Lalinsky
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development